Uploaded image for project: 'Hippo Site Toolkit 2'
  1. Hippo Site Toolkit 2
  2. HSTTWO-4107

[Backport 11.2] Resource bundle ID(s) configuration as channel info parameter to the bundle fallback mechanism in LocalizationValve

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Won't Do
    • Affects Version/s: 4.2.3
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Similar issues:
    • Sprint:
      Turing Sprint 168, Turing Sprint 169

      Description

      want the business users to be able to set the global resource bundle(s) for a channel through the channel setting dialog, so that they can configure different labels, for example, for the copyright notice at the bottoms of all the page.
      When I see the LocalizationValve of HST-2, it's reading resource bundle id properties from sitemapitem or mount configuration:

                  if (requestContext.getResolvedSiteMapItem() != null) {
                      bundleIds = requestContext.getResolvedSiteMapItem().getHstSiteMapItem().getResourceBundleIds();
                  } else {
                      bundleIds = requestContext.getResolvedMount().getMount().getDefaultResourceBundleIds();
                  }
      

      Would be an idea to improve that to read channel settings as well.
      For example,

          String bundleIds = (String) requestContext.getResolvedMount().getMount().getChannelInfo().getProperties().get(RESOURCE_BUNDLE_ID);
      

      Channel should be the first location than others to look into If set.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                wko Woonsan Ko
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: