Uploaded image for project: '[Read Only] - Hippo Site Toolkit 2'
  1. [Read Only] - Hippo Site Toolkit 2
  2. HSTTWO-4106

Resource bundle ID(s) configuration as channel info parameter to the bundle fallback mechanism in LocalizationValve

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • None
    • 5.1.0
    • None
    • None
    • Turing Sprint 168, Turing Sprint 169

    Description

      want the business users to be able to set the global resource bundle(s) for a channel through the channel setting dialog, so that they can configure different labels, for example, for the copyright notice at the bottoms of all the page.
      When I see the LocalizationValve of HST-2, it's reading resource bundle id properties from sitemapitem or mount configuration:

                  if (requestContext.getResolvedSiteMapItem() != null) {
                      bundleIds = requestContext.getResolvedSiteMapItem().getHstSiteMapItem().getResourceBundleIds();
                  } else {
                      bundleIds = requestContext.getResolvedMount().getMount().getDefaultResourceBundleIds();
                  }
      

      Would be an idea to improve that to read channel settings as well.
      For example,

          String bundleIds = (String) requestContext.getResolvedMount().getMount().getChannelInfo().getProperties().get(RESOURCE_BUNDLE_ID);
      

      Channel should be the first location than others to look into If set.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              wko Woonsan Ko (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: