Details
-
Improvement
-
Status: Closed
-
High
-
Resolution: Fixed
-
r2.12.04
-
None
Description
StringCodecFactory was introduced to support readable urls and is currently used in core Hippo CMS Plugins.
Our project relies on this infrastructure factory in order to hook up our custom naming scheme.
In the process of implementing the custom naming scheme, I found some issues with the current implementation as mentioned below.
1] direct use of Class.forName introduces potential class loading issues
2] any exception that could occur loading a StringCodec class or instantiating it, are silently swallowed, returning null
3] StringCodecs class definitions are reloaded on each 'getStringCodec(String ...)' call, introducing a performance hit
4] 'getStringCodec()' method is unused and even when called would produce NullPointerException
5] missing documentation
6] missing behavior change detectors (tests)
I have addressed these issues in the patch attached (for trunk, rev 21850).
Please review.
Kind regards,
Rob van der Linden Vooren