Uploaded image for project: 'Hippo CMS'
  1. Hippo CMS
  2. CMS-606

DeleteDialog in the cms-prototype should not recursively search for a hippo:handle to delete, but the delete should only be visible when present

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Top
    • Resolution: Fixed
    • 2.01.00m03
    • 2.01.00m06
    • addon-cms-prototype
    • None

    Description

      See emaiL

      'AFAIU, this means that if you click delete on some node three levels below a hippo handle (which ideally you would not see in the cms, but suppose you would for some reason) (for example, a picture in a paragraph), then, the delete actually finds place on the parent parent node. This seems really dangerous to me!

      My suggestion: In actions, only show 'delete' when clicked on a hippo:handle

      In de ok() in deleteDialog, only delete if type is op hippo:handle, otherwise popup exception. Do not recursively search for a hippo:handle to delete IMHO.

      So, toBeDeleted = Utils.findHandle(node); should be removed IMO.'

      and

      'The delete function should go through the workflow process anyway.
      Being able to delete a complete handle is very useful, though. So don't throw it away. But adding some UI friendliness would be appreciated'

      Attachments

        Issue Links

          Activity

            People

              aschrijvers Ard Schrijvers
              aschrijvers Ard Schrijvers
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: