Uploaded image for project: 'Hippo CMS'
  1. Hippo CMS
  2. CMS-12710

Let a cancelled angular form return the correct rejection type

    XMLWordPrintable

Details

    • Improvement
    • Status: Open
    • Normal
    • Resolution: Unresolved
    • None
    • None
    • channel-manager
    • None

    Description

      In the RightSidePanel.js there is a method called close that will call state.go to navigate to the channel overview. When there are changes open in the rightside panel, then a dialog pops up that allows the user to save/discard changes or to cancel the navigation.

      When the user chooses to cancel then the routing is cancelled by means of a rejected promise containing a instance of class Rejection. According to the router documentation there are several types of rejections See class Rejection.

      When the user chooses to cancel I expected the rejection.type to be RejectType.ABORTED but instead it was RejectType.ERROR. This looks like to be a bug to me.

      .

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              meggermont Michiel Eggermont (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: