Uploaded image for project: 'Hippo CMS'
  1. Hippo CMS
  2. CMS-10557

Replace custom reading Implementation-* from MANIFEST.MF by java.lang.Package methods

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • None
    • 4.2.0
    • None
    • None
    • Pulsar
    • Platform Sprint 145, Platform Sprint 147

    Description

      There are some that have been reading Implementation-* attributes from the MANIFEST.MF resource manually by manipulating relative URL path using ../../../../, which doesn't seem to be very safe, as explained in HSTTWO-3890.

      I'd like to propose changes in the following:

      • org.hippoecm.frontend.model.SystemInfoDataProvider.getCMSVersion() should simply use Home.class.getPackage().getImplementationVersion() and Home.class.getPackage().getImplementationBuild().

      Attachments

        Issue Links

          relates to

          Improvement - An improvement or enhancement to an existing feature or task. HSTTWO-3890 HstServices#getImplementationVersion() might not work in non-Tomcat or jar-non-exploded envs

          • Normal - Normal priority, tasks to be done before next intermediate release
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. REPO-1607 Replace custom reading Implementation-* from MANIFEST.MF by java.lang.Package methods

          • Normal - Normal priority, tasks to be done before next intermediate release
          • Closed

          Activity

            People

              Unassigned Unassigned
              wko Woonsan Ko (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: