Uploaded image for project: '[Read Only] - Addon Channel Manager'
  1. [Read Only] - Addon Channel Manager
  2. CHANNELMGR-1447

Simplify lookup of parent ExtJs panel

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • 5.0.1, 5.1.0
    • 5.1.0
    • None
    • Tiger Sprint 164

    Description

      The Channel Manager app lives in an iframe, which lives in an ExtJs panel in the top-level DOM. The Channel Manager accesses this ExtJs panel via window.parent.Ext.getCmp('id-of-panel'). The ID is currently passed to the app via query parameter in the URL of the iframe. That's unnecessarily complex, since the ID is always the same. The lookup in the query parameter also requires mocking it in unit tests, which introduces even more complexity.

      The lookup should be replaced with a constant.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              mdenburger Mathijs den Burger (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: